Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remote execution test setup and tear down broken #12377

Closed
meisterT opened this issue Oct 28, 2020 · 0 comments
Closed

remote execution test setup and tear down broken #12377

meisterT opened this issue Oct 28, 2020 · 0 comments
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team type: bug untriaged

Comments

@meisterT
Copy link
Member

Description of the problem / feature request:

When testing //src/test/shell/bazel/remote:remote_execution_test, we saw that the setup and tear_down methods both seem to be broken:

test_fail FAILED: Timed out waiting for remote worker to start. .
/usr/local/google/home/twerth/.cache/bazel/_bazel_twerth/f01bc937da326f5bb0feb15c854c110c/sandbox/linux-sandbox/1546/execroot/io_bazel/bazel-out/k8-fastbuild/bin/src/test/shell/bazel/remote/remote_execution_test.runfiles/io_bazel/src/test/shell/bazel/remote/remote_utils.sh:41: in call to start_worker
/usr/local/google/home/twerth/.cache/bazel/_bazel_twerth/f01bc937da326f5bb0feb15c854c110c/sandbox/linux-sandbox/1546/execroot/io_bazel/bazel-out/k8-fastbuild/bin/src/test/shell/bazel/remote/remote_execution_test.runfiles/io_bazel/src/test/shell/bazel/remote/remote_execution_test:49: in call to set_up
INFO[remote_execution_test 2020-10-28 15:54:28 (+0000)] Cleaning up workspace
-- Test log: -----------------------------------------------------------
$TEST_TMPDIR defined: output root default is '/usr/local/google/home/twerth/.cache/bazel/_bazel_twerth/f01bc937da326f5bb0feb15c854c110c/sandbox/linux-sandbox/1546/execroot/io_bazel/_tmp/e29069609bc298cb3b1996e685786dd3' and max_idle_secs default is '15'.
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
INFO: Starting clean (this may take a while). Consider using --async if the clean takes more than several minutes.
$TEST_TMPDIR defined: output root default is '/usr/local/google/home/twerth/.cache/bazel/_bazel_twerth/f01bc937da326f5bb0feb15c854c110c/sandbox/linux-sandbox/1546/execroot/io_bazel/_tmp/e29069609bc298cb3b1996e685786dd3' and max_idle_secs default is '15'.
INFO: Starting clean (this may take a while). Consider using --async if the clean takes more than several minutes.
------------------------------------------------------------------------
test_fail FAILED: terminated because this command returned a non-zero status:
/usr/local/google/home/twerth/.cache/bazel/_bazel_twerth/f01bc937da326f5bb0feb15c854c110c/sandbox/linux-sandbox/1546/execroot/io_bazel/bazel-out/k8-fastbuild/bin/src/test/shell/bazel/remote/remote_execution_test.runfiles/io_bazel/src/test/shell/bazel/remote/remote_execution_test:2272: in call to main
/usr/local/google/home/twerth/.cache/bazel/_bazel_twerth/f01bc937da326f5bb0feb15c854c110c/sandbox/linux-sandbox/1546/execroot/io_bazel/bazel-out/k8-fastbuild/bin/src/test/shell/bazel/remote/remote_execution_test.runfiles/io_bazel/src/test/shell/bazel/remote/remote_utils.sh: line 46: pid_file: unbound variable
$TEST_TMPDIR defined: output root default is '/usr/local/google/home/twerth/.cache/bazel/_bazel_twerth/f01bc937da326f5bb0feb15c854c110c/sandbox/linux-sandbox/1546/execroot/io_bazel/_tmp/e29069609bc298cb3b1996e685786dd3' and max_idle_secs default is '15'.

Notice the timeout in the first line and the unbound variable in one of the last lines.

Seems to happen with released Bazel and Bazel at HEAD on both Linux and Mac.
@meteorcloudy meteorcloudy mentioned this issue Oct 28, 2020
Closed
@philwo philwo added team-Remote-Exec Issues and PRs for the Execution (Remote) team untriaged type: bug labels Nov 10, 2020
meteorcloudy added a commit to meteorcloudy/bazel that referenced this issue Dec 4, 2020
@meteorcloudy
Fix //src/test/shell/bazel/remote:remote_execution_test test
5be8952 
The stop_worker function in remote_utils.sh was broken with an unbounded
variable error. This error somehow shadowed the return code of the test
cases on macOS.

Fixes bazelbuild#12377
Fixes bazelbuild#12376
meteorcloudy added a commit to meteorcloudy/bazel that referenced this issue Dec 4, 2020
@meteorcloudy
Fix //src/test/shell/bazel/remote:remote_execution_test test
0f75e5e 
The stop_worker function in remote_utils.sh was broken with an unbounded
variable error. This error somehow shadowed the return code of the test
cases on macOS.

Fixes bazelbuild#12377
Fixes bazelbuild#12376
@meteorcloudy meteorcloudy mentioned this issue Dec 4, 2020
Closed
@meteorcloudy meteorcloudy mentioned this issue Dec 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team type: bug untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix //src/test/shell/bazel/remote:remote_execution_test test meteorcloudy/bazel
2 participants
@meisterT @philwo