Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.4.0] Allow unquoted canonical repository names with query #23601

Closed
bazel-io opened this issue Sep 11, 2024 · 3 comments
Closed

[7.4.0] Allow unquoted canonical repository names with query #23601

bazel-io opened this issue Sep 11, 2024 · 3 comments
Milestone
7.4.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #23600
@bazel-io bazel-io added this to the 7.4.0 release blockers milestone Sep 11, 2024
@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/query2/engine/Lexer.java

cc: @bazelbuild/triage

@iancha1992
Copy link
Member

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/query2/engine/Lexer.java

cc: @bazelbuild/triage

cc: @fmeum @Wyverald

@fmeum fmeum mentioned this issue Sep 19, 2024
Merged
@iancha1992
Copy link
Member

Cherry-picked in #23675

github-merge-queue bot pushed a commit that referenced this issue Sep 19, 2024
@fmeum
[7.4.0] Allow unquoted canonical repository names with query (#23675)
3300d15 
Unquoted `query` words that start with `@@` are no longer broken on `+`,
which allows the usage of unquoted canonical labels in expressions. In
the very rare case of a shorthand form of a canonical label referring to
a WORKSPACE repo (which contains no `+`), the `+` can be separated by a
space to get the original behavior (e.g. `@@foo+bar` no longer means
`@@foo//:foo + //bar:bar`, but `@@foo +bar` does.

Closes #23600.

PiperOrigin-RevId: 673763980
Change-Id: Ie5509647b4e04e2f72b908d609781c79cf7b06d4

Fixes #23601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.4.0 release blockers
Development

No branches or pull requests
3 participants
@Wyverald @bazel-io @iancha1992