Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

//src/test/java/com/google/devtools/build/lib:remote-tests is very flaky #5328

Closed
aehlig opened this issue Jun 5, 2018 · 3 comments
Closed
Assignees
Labels
P1 I'll work on this now. (Assignee required) type: bug

Comments

@aehlig
Copy link
Contributor

aehlig commented Jun 5, 2018

The test //src/test/java/com/google/devtools/build/lib:remote-tests is flaky to an extend that it showed up several times as a spurious failure in our CI system, despite this CI system running with --flaky_test_attempts=3.

A quick check doing 100 runs of the test on my corp desktop showed 16 failures, but the flakyness seems to be worse of the CI machines.

@aehlig aehlig added type: bug P1 I'll work on this now. (Assignee required) category: remote execution / caching labels Jun 5, 2018
@laszlocsomor
Copy link
Contributor

Example flake in "Bazel Remote Execution" on CI (Bazel with downstream projects #298; see log file):

1) multipleBlobsUploadShouldWork(com.google.devtools.build.lib.remote.ByteStreamUploaderTest)
java.lang.Exception: test timed out after 20000 milliseconds
	at java.lang.Thread.sleep(Native Method)
	at com.google.devtools.build.lib.remote.ByteStreamUploaderTest.blockUntilInternalStateConsistent(ByteStreamUploaderTest.java:697)
	at com.google.devtools.build.lib.remote.ByteStreamUploaderTest.multipleBlobsUploadShouldWork(ByteStreamUploaderTest.java:292)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)

@ulfjack
Copy link
Contributor

ulfjack commented Jun 12, 2018

  1. singleBlobUploadShouldWork(com.google.devtools.build.lib.remote.ByteStreamUploaderTest)
    java.lang.Exception: test timed out after 10000 milliseconds
    at java.lang.Thread.sleep(Native Method)
    at com.google.devtools.build.lib.remote.ByteStreamUploaderTest.blockUntilInternalStateConsistent(ByteStreamUploaderTest.java:697)
    at com.google.devtools.build.lib.remote.ByteStreamUploaderTest.singleBlobUploadShouldWork(ByteStreamUploaderTest.java:201)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
    at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)

@fweikert
Copy link
Member

Culprit is ebe1ec8
Doubling the timeout doesn't help. We can either increase the timeout even more, roll back the CL or disable the test.

bazel-io pushed a commit that referenced this issue Jun 12, 2018
Temporary workaround for #5328.

PiperOrigin-RevId: 200224317
bazel-io pushed a commit that referenced this issue Jun 13, 2018
Onto #5328

PiperOrigin-RevId: 200410170
ArielleA pushed a commit to ArielleA/bazel that referenced this issue Jun 19, 2018
Temporary workaround for bazelbuild#5328.

PiperOrigin-RevId: 200224317
ArielleA pushed a commit to ArielleA/bazel that referenced this issue Jun 19, 2018
Onto bazelbuild#5328

PiperOrigin-RevId: 200410170
werkt pushed a commit to werkt/bazel that referenced this issue Aug 2, 2018
Temporary workaround for bazelbuild#5328.

PiperOrigin-RevId: 200224317
werkt pushed a commit to werkt/bazel that referenced this issue Aug 2, 2018
Onto bazelbuild#5328

PiperOrigin-RevId: 200410170
@buchgr buchgr closed this as completed Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 I'll work on this now. (Assignee required) type: bug
Projects
None yet
Development

No branches or pull requests

5 participants