Allow disabling android resource merging via android_non_transitive_r_class configuration option
#15806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r_class` configuration option With this change each `android_library` target will generate `R` class with entries only from current local target instead of including entries from transitive closure of dependencies usually created via a separate merging action. `R` entries from libraries should be referenced by their fully qualified name otherwise build would fail.
sgowroji
added
team-Android
|
Hello @arunkumar9t2, Can you please check build failures and Code conflict. Thank you! |
|
@arunkumar9t2 We are marking the above PR as stale because it has not had any recent activity from many days. |
|
Thank you for contributing to the Bazel repository! This pull request has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-review", "awaiting-PR-merge". Please reach out to the triage team ( |
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change each
android_librarytarget will generateRclass with entries only from current local target instead of including entries from transitive closure of dependencies usually created via a separate merging action.Rentries from libraries should be referenced by their fully qualified name otherwise build would fail.Reference: https://developer.android.com/studio/build/optimize-your-build#use-non-transitive-r-classes
In our large android app, we save several thousand actions and reduce cache output by 1.1 GB.
Adapted from #11385 and renamed flag to be in line with Android Gradle plugin flag.
Fixes bazelbuild/rules_android#10