Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip incompatible_enable_cc_toolchain_resolution #16252

Closed
wants to merge 16 commits into from
Closed

Flip incompatible_enable_cc_toolchain_resolution #16252

wants to merge 16 commits into from

Conversation

comius
Copy link
Contributor

@comius comius commented Sep 12, 2022 •
edited
Loading

RELNOTES[INC]: Flip incompatible_enable_cc_toolchain_resolution (#7260)

@comius comius requested a review from lberki as a code owner September 12, 2022 08:32
@comius comius removed the request for review from lberki September 12, 2022 08:32
@comius comius marked this pull request as draft September 12, 2022 08:32
lberki
lberki approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@lberki lberki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I mean, it will be great when it sticks, but merging this pull request is a necessary part of the path for getting there :)

@comius
Copy link
Contributor Author

comius commented Sep 19, 2022 •
edited
Loading

Downstream tests: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2641#01835443-ca23-4d89-b700-dd2ef89c8f7a

Failures:

@comius comius changed the title Flip cc toolchain resolution Flip incompatible_enable_cc_toolchain_resolution Sep 19, 2022
@comius comius marked this pull request as ready for review September 19, 2022 11:24
@comius
Copy link
Contributor Author

comius commented Sep 19, 2022

Failing test needs rules_cc 0.0.2 on bzlmod repository.

@meteorcloudy meteorcloudy mentioned this pull request Sep 19, 2022
Merged
@meteorcloudy
Copy link
Member

You can also view the broken downstream project here:
https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1264

image

@ShreeM01 ShreeM01 added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Sep 20, 2022
@comius comius requested a review from lberki September 20, 2022 08:38
@skeletonkey skeletonkey mentioned this pull request Sep 21, 2022
Merged
aiuto pushed a commit to aiuto/bazel that referenced this pull request Oct 12, 2022
@comius @aiuto
Flip incompatible_enable_cc_toolchain_resolution
615a5cd 
RELNOTES[INC]: Flip incompatible_enable_cc_toolchain_resolution (bazelbuild#7260)

Closes bazelbuild#16252.

PiperOrigin-RevId: 476058407
Change-Id: I6ceb9cd306e0eeed61cb1ff8cd9804d26988d22d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy Awaiting requested review from meteorcloudy

@oquenchil oquenchil Awaiting requested review from oquenchil

@lberki lberki Awaiting requested review from lberki lberki is a code owner

Assignees
No one assigned
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Rules-CPP Issues for C++ rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@comius @meteorcloudy @lberki @ShreeM01