Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 6.4.0 remote #18959

Merged
merged 5 commits into from
Jul 25, 2023
Merged

Commits on Jul 24, 2023

  1. Include stack trace in all gRPC errors when --verbose_failures is set.

    Also refactor a couple places where the stack trace was included in an ad-hoc
    manner, and force Utils.grpcAwareErrorMessage callers to be explicit to avoid
    future instances.
    
    Closes bazelbuild#16086.
    
    PiperOrigin-RevId: 502854490
    Change-Id: Id2d6a1728630fffea9399b406378c7f173b247bd
    tjgq authored and werkt committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    399c541 View commit details
    Browse the repository at this point in the history
  2. Avoid discarding SRE state for IO cause

    Unwrapping all StatusRuntimeExceptions in in ReferenceCountedChannel when caused by IOException will discard critical tracing and retriability. The Retrier evaluations may not see an SRE in the causal chain, and presume it is invariably an unretriable exception. In general, IOExceptions as SRE wrappers are unsuitable containers and are routinely misued either for identification (grpc aware status), or capture (handleInitError).
    
    Partially addresses bazelbuild#18764 (retries will occur with SSL handshake timeout, but the actual connection will not be retried)
    
    Closes bazelbuild#18836.
    
    PiperOrigin-RevId: 546037698
    Change-Id: I7f6efcb857c557aa97ad3df085fc032c8538eb9a
    werkt committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    4cc0682 View commit details
    Browse the repository at this point in the history
  3. Operation stream termination is not an error

    According to the GrpcRemoteExecutor when it occurs after a !done operation response. Remove the error from the
    ExperimentalRemoteGrpcExecutor and reinforce both with tests.
    
    Update the FakeExecutionService to generate compatible error responses that appear in the ExecuteResponse, rather than the operation error field, per the REAPI spec. Made required adjustments to ExGRE Test invocations to avoid the ExecutionStatusException interpretation of DEADLINE_EXCEEDED -> FAILED_PRECONDITION in ExecuteResponse.
    
    Closes bazelbuild#18785.
    
    PiperOrigin-RevId: 546925894
    Change-Id: I7a489c8bc936a83cfd94e0138437f3fe6d152da8
    werkt committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    ca67dee View commit details
    Browse the repository at this point in the history
  4. Done operations must be reexecuted

    Any operation with done == true as reported by the server is not expected to change its result on subsequent waitExecution calls. To properly retry, this action must be reexecuted, if it was truly transient, to achieve a definitive result. Submit a transient status for retry, disallow special behaviors for NOT_FOUND as covered by done observation, and consider method type when handling operation streams.
    
    Closes bazelbuild#18943.
    
    PiperOrigin-RevId: 548680656
    Change-Id: Ib2c9887ead1fbd3de97761db6e8b4077783ad03c
    werkt committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    d8e520a View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Configuration menu
    Copy the full SHA
    33227d7 View commit details
    Browse the repository at this point in the history