Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Duplicate] Add toolchain type for Java bootstrap runtime #19216

Closed
wants to merge 2 commits into from

Conversation

iancha1992
Copy link
Member

The bootclasspath rule in rules_java will soon use this toolchain type instead of the regular Java runtime toolchain type, which naturally carries a constraint on the target platform.

Also adds more detailed explanations of the now three Java toolchain types.

Work towards #17085 Work towards #18265 Work towards bazelbuild/rules_java#64 Split off from #18262

Commit 8715e9a

Closes #18841.

PiperOrigin-RevId: 545756139
Change-Id: Ib9dd7a1c20c32315375722d6a023a89859daea9c

The `bootclasspath` rule in `rules_java` will soon use this toolchain type instead of the regular Java runtime toolchain type, which naturally carries a constraint on the target platform.

Also adds more detailed explanations of the now three Java toolchain types.

Work towards bazelbuild#17085
Work towards bazelbuild#18265
Work towards bazelbuild/rules_java#64
Split off from bazelbuild#18262

Closes bazelbuild#18841.

PiperOrigin-RevId: 545756139
Change-Id: Ib9dd7a1c20c32315375722d6a023a89859daea9c
@iancha1992 iancha1992 added team-Rules-Java Issues for Java rules awaiting-review PR is awaiting review from an assigned reviewer labels Aug 9, 2023
@iancha1992 iancha1992 requested a review from a team as a code owner August 9, 2023 17:54
@iancha1992 iancha1992 enabled auto-merge (squash) August 9, 2023 17:54
@iancha1992 iancha1992 removed team-Rules-Java Issues for Java rules awaiting-review PR is awaiting review from an assigned reviewer labels Aug 9, 2023
@iancha1992 iancha1992 removed the request for review from a team August 9, 2023 18:10
@iancha1992 iancha1992 closed this Aug 9, 2023
auto-merge was automatically disabled August 9, 2023 18:10

Pull request was closed

@iancha1992 iancha1992 changed the title [6.4.0] Add toolchain type for Java bootstrap runtime [Duplicate] Add toolchain type for Java bootstrap runtime Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants