Deduplicate locally executed path mapped spawns #22556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
21043-deduplicate-action
branch
from
27e14e8
to
ef83b2a
Compare
github-actions
bot
added
team-Performance
|
@tjgq Gentle ping |
tjgq
requested changes
Jul 4, 2024
src/main/java/com/google/devtools/build/lib/remote/RemoteExecutionService.java
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/remote/RemoteExecutionService.java
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/remote/RemoteExecutionService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/remote/RemoteExecutionService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/remote/RemoteExecutionService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/remote/RemoteExecutionService.java
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnCache.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/remote/RemoteExecutionService.java
Show resolved
Hide resolved
src/test/java/com/google/devtools/build/lib/remote/RemoteSpawnCacheTest.java
Outdated
Show resolved
Hide resolved
fmeum
force-pushed
the
21043-deduplicate-action
branch
from
ef83b2a
to
92a4694
Compare
fmeum
force-pushed
the
21043-deduplicate-action
branch
from
422589d
to
5294ef0
Compare
tjgq
approved these changes
Jul 22, 2024
|
I'll import this myself. |
|
@bazel-io fork 7.3.0 |
github-actions
bot
removed
the
awaiting-review
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jul 23, 2024
When path mapping is enabled, different `Spawn`s in the same build can have identical `RemoteAction.ActionKey`s and can thus provide remote cache hits for each other. However, cache hits are only possible after the first local execution has concluded and uploaded its result to the cache. To avoid unnecessary duplication of local work, the first `Spawn` for each `RemoteAction.ActionKey` is tracked until its results have been uploaded and all other concurrently scheduled `Spawn`s wait for it and then copy over its local outputs. Fixes bazelbuild#21043 Closes bazelbuild#22556. PiperOrigin-RevId: 655097996 Change-Id: I4368f9210c67a306775164d252aae122d8b46f9b
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
When path mapping is enabled, different `Spawn`s in the same build can have identical `RemoteAction.ActionKey`s and can thus provide remote cache hits for each other. However, cache hits are only possible after the first local execution has concluded and uploaded its result to the cache. To avoid unnecessary duplication of local work, the first `Spawn` for each `RemoteAction.ActionKey` is tracked until its results have been uploaded and all other concurrently scheduled `Spawn`s wait for it and then copy over its local outputs. Fixes #21043 Closes #22556. PiperOrigin-RevId: 655097996 Change-Id: I4368f9210c67a306775164d252aae122d8b46f9b Closes #23060
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
Cherry-picks the following changes to implement output reuse: * Deduplicate locally executed path mapped spawns (#22556) * Fix local execution deduplication to work with optional outputs (#23296) * Force synchronous upload and reuse of possibly modified spawn outputs (#23382) * Add support for in-memory outputs to output reuse (#23422) Fixes #23377 Fixes #23444 Fixes #23457
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When path mapping is enabled, different
Spawns in the same build can have identicalRemoteAction.ActionKeys and can thus provide remote cache hits for each other. However, cache hits are only possible after the first local execution has concluded and uploaded its result to the cache.To avoid unnecessary duplication of local work, the first
Spawnfor eachRemoteAction.ActionKeyis tracked until its results have been uploaded and all other concurrently scheduledSpawns wait for it and then copy over its local outputs.Fixes #21043