Use + instead of ~ as the canonical repo name separator
#23098
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wyverald
force-pushed
the
wyv-repo-plus
branch
6 times, most recently
from
0e9c0a5
to
9f2d3ea
Compare
Wyverald
changed the title
+ instead of ~ as the canonical repo name separator+ instead of ~ as the canonical repo name separator
Wyverald
requested review from
a team,
gregestren,
fweikert and
meteorcloudy
as code owners
Wyverald
requested review from
fmeum
and removed request for
a team,
gregestren and
fweikert
github-actions
bot
added
team-Configurability
Wyverald
removed
team-Configurability
fmeum
approved these changes
Jul 30, 2024
github-actions
bot
removed
the
awaiting-review
5 tasks
honnix
added a commit
to honnix/rules_ruby
that referenced
this pull request
Oct 16, 2024
To prepare for bazelbuild/bazel#23098
p0deje
pushed a commit
to bazel-contrib/rules_ruby
that referenced
this pull request
Oct 16, 2024
To prepare for bazelbuild/bazel#23098
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR essentially flips
--incompatible_use_plus_in_repo_names(introduced in #23103) to true on master. In addition, it graveyards the flag, removes all logic to use~, and fixes all tests to use+instead.