Reduce verbosity of BulkTransferException #23490
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulrfa
force-pushed
the
BulkTransferException
branch
from
5932356
to
d5faaa9
Compare
BulkTransferException was sometimes overly verbose in the console, particularly when many transfers failed for the same reason. This commit shortens and normalizes BulkTransferException messages to improve the efficiency of existing event deduplication, such as that performed by RemoteExecutionService.report(). Normalization involves not mentioning individual digests in exception messages from ByteStreamUploader. Instead, we now wrap StatusRuntimeException directly in an IOException, which is a common pattern in GrpcCacheClient.
ulrfa
force-pushed
the
BulkTransferException
branch
from
d5faaa9
to
9bb8719
Compare
github-actions
bot
added
team-Remote-Exec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BulkTransferException was sometimes overly verbose in the console, particularly when many transfers failed for the same reason.
This commit shortens and normalizes BulkTransferException messages to improve the efficiency of existing event deduplication, such as that performed by RemoteExecutionService.report().
Normalization involves not mentioning individual digests in exception messages from ByteStreamUploader. Instead, we now wrap StatusRuntimeException directly in an IOException, which is a common pattern in the GrpcCacheClient.