Add the option to include sources in the native maven_jar rule #3571
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to download the sources jar (defined as the same maven artifact, but with classifier = "sources") along with the main jar. When doing so it will specify the
srcjar
attribute on thejava_import
rule generated bymaven_jar
.The motivation behind this is improving IDE integration for third party dependencies, specifically allowing the IJ plugin to automatically attach sources to maven jars without having to use custom Skylark macros.
This also adds in the option to specify a
sources_sha1
, though I'm not sure how useful that is.Example of generated BUILD file:
Discussed in #1410 & #308