Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommandBuilder: remove useShell and setWorkingDir #5007

Closed
wants to merge 3 commits into from
Closed

CommandBuilder: remove useShell and setWorkingDir #5007

wants to merge 3 commits into from

Commits on Apr 12, 2018

  1. CommandBuilder: remove useShell and setWorkingDir 

    Remove the .useShell method, expect callers to
just pass the shell interpreter if they need it.
This removes the argument vector transformation
heuristic, and stops shelling out to cmd.exe on
Windows. See bazelbuild#2190

Also remove the .setWorkingDir method because
callers always had to set the working directory.
Instead, the CommandBuilder constructor takes the
working directory.

Change-Id: I545e01c811daaf34913cb585492923da81aa02ee
    @laszlocsomor
    laszlocsomor committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    93cb265 View commit details
    Browse the repository at this point in the history

  2. Fix workspace status test. 

    Change-Id: I7a694c9761e202e31352e69711e0c596dc51f905
    @laszlocsomor
    laszlocsomor committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    3ab754c View commit details
    Browse the repository at this point in the history

  3. Fix CleanCommand. 

    Change-Id: I09dc604a0c5d53dc864e836ddc091b81aae590a2
    @laszlocsomor
    laszlocsomor committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    534b628 View commit details
    Browse the repository at this point in the history