shell,tests: use Bash runfiles library in one test #5387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See bazelbuild#4930 Change-Id: I148c0b1e4baa8ff44d86a6ee196bea7e9058320f
Change-Id: I85fe8ae81f0d928e25e5f42261346a6592892f7f
| @@ -501,7 +507,6 @@ function assert_bazel_run() { | |||
| } | |||
|
|
|||
| setup_bazelrc | |||
| setup_clean_workspace | |||
There was a problem hiding this comment.
Because it's also called again in create_and_cd_client here: https://github.com/bazelbuild/bazel/pull/5387/files/ea9aaba28fff52d3332c07bc6c3ad444c4910f38#diff-c467ef71bdf4e156e40ab02be09dccd5R540
meteorcloudy
approved these changes
Jun 14, 2018
| @@ -501,7 +507,6 @@ function assert_bazel_run() { | |||
| } | |||
|
|
|||
| setup_bazelrc | |||
| setup_clean_workspace | |||
Change-Id: I249c9492d632a9b9ee9bc8bf0e921caf375a6cb1
|
I added 4b36391 because the test was failing on Mac on BuildKite. I hope it will fix that. |
Change-Id: Iba32f21ff6cad1b538c72cfd08ce24846843c124
|
Looks like it's fixed! |
ArielleA
pushed a commit
to ArielleA/bazel
that referenced
this pull request
Jun 19, 2018
See bazelbuild#4930 Change-Id: I148c0b1e4baa8ff44d86a6ee196bea7e9058320f Closes bazelbuild#5387. Change-Id: Iba32f21ff6cad1b538c72cfd08ce24846843c124 PiperOrigin-RevId: 200554084
werkt
pushed a commit
to werkt/bazel
that referenced
this pull request
Aug 2, 2018
See bazelbuild#4930 Change-Id: I148c0b1e4baa8ff44d86a6ee196bea7e9058320f Closes bazelbuild#5387. Change-Id: Iba32f21ff6cad1b538c72cfd08ce24846843c124 PiperOrigin-RevId: 200554084
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4930
Change-Id: I148c0b1e4baa8ff44d86a6ee196bea7e9058320f