Add Windows ARM64 and Refactored Targets #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ating a new go_test target
…go_binary targets (stripped and not stripped)
albertocavalcante
force-pushed
the
add-windows-arm64
branch
from
6906823
to
a6e9986
Compare
|
@meteorcloudy @fweikert can you please review? |
|
جيد |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Gazelle targets haven't been updated in a while. Took this opportunity to re-generate them.
Also, the
BUILDfile had manygo_binarydirectives even though there are just two flavors: a stripped binary and another with all the symbols. Refactored to dinamically generate those based on theos,archwe should have for each flavor.Added
windows-arm64, tested in a workstation on Azure. Find evidence below.Warning
bazelisk.js: The NodeJS version installed in the machine must be ARM, otherwise
os.arch()returnsx64and it will use thewindows_amd64binary.Installed from:
npm i -g @bazel/bazelisk --registry=https://albertocavalcante.jfrog.io/artifactory/api/npm/bazel-npm-localTest Evidence
Tested on a Windows ARM4 machine.
Context: bazelbuild/bazel#22164
Fixes #572