Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unused_deps doesn't support BUILD.bazel files #204

Closed
uppi opened this issue Feb 8, 2018 · 1 comment · Fixed by #728
Closed

unused_deps doesn't support BUILD.bazel files #204

uppi opened this issue Feb 8, 2018 · 1 comment · Fixed by #728
Assignees
@pmbethe09

Comments

@uppi
Copy link

uppi commented Feb 8, 2018

According to bazelbuild/bazel#552, BUILD.bazel is a valid name for BUILD file, but unused_deps called on the target with BUILD.bazel file tries to open BUILD and fails:

2018/02/08 19:00:32 open /some/path/BUILD: no such file or directory when parsing /some/path/BUILD
@pmbethe09
Copy link
Member

Seems to be from InterpretLabelForWorkspaceLocation in edit/edit.go

@pmbethe09 pmbethe09 self-assigned this Apr 20, 2018
aljoscha added a commit to aljoscha/buildtools that referenced this issue Oct 5, 2019
@aljoscha
unused_deps: Support BUILD.bazel files
76e22dd 
Before, we would only support BUILD files. Now, we check if the BUILD
file exists, if not we add the .bazel extension and return that.

This fixes bazelbuild#204
This fixes bazelbuild#441
@aljoscha aljoscha mentioned this issue Oct 5, 2019
Merged
vladmos pushed a commit that referenced this issue Oct 9, 2019
@aljoscha @vladmos
unused_deps: Support BUILD.bazel files (#728)
a795ddb 
Before, we would only support BUILD files. Now, we check if the BUILD
file exists, if not we add the .bazel extension and return that.

This fixes #204
This fixes #441
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmbethe09 pmbethe09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unused_deps: Support BUILD.bazel files aljoscha/buildtools
2 participants
@uppi @pmbethe09