Add EP to extend external modules (#6467)

Added an EP to give the feasibility to allow other modules. For example, when maven modules are added into project view bazel sync resets the view as they have different content root. An implementation could be added to allow maven modules to be shown in project tree view.
bazelbuild · Jun 13, 2024 · 56fc692 · 56fc692
1 parent ca9c95e
commit 56fc692
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/base/src/META-INF/blaze-base.xml b/base/src/META-INF/blaze-base.xml
@@ -508,6 +508,8 @@
       interface="com.google.idea.blaze.base.qsync.BlazeProjectListenerProvider"/>
     <extensionPoint qualifiedName="com.google.idea.blaze.base.qsync.ProjectProtoTransformProvider"
       interface="com.google.idea.blaze.base.qsync.ProjectProtoTransformProvider"/>
+    <extensionPoint qualifiedName="com.google.idea.blaze.base.sync.projectstructure.ExternalModuleProvider"
+                    interface="com.google.idea.blaze.base.sync.projectstructure.ExternalModuleProvider"/>
 
   </extensionPoints>
 

diff --git a/base/src/com/google/idea/blaze/base/sync/projectstructure/ExternalModuleProvider.java b/base/src/com/google/idea/blaze/base/sync/projectstructure/ExternalModuleProvider.java
@@ -0,0 +1,14 @@
+package com.google.idea.blaze.base.sync.projectstructure;
+
+import com.intellij.openapi.extensions.ExtensionPointName;
+import com.intellij.openapi.module.Module;
+
+/**
+ * An EP provider for external modules.
+ */
+public interface ExternalModuleProvider {
+    ExtensionPointName<ExternalModuleProvider> EP_NAME =
+            ExtensionPointName.create("com.google.idea.blaze.base.sync.projectstructure.ExternalModuleProvider");
+
+    boolean isOwnedByExternalPlugin(Module module);
+}
diff --git a/base/src/com/google/idea/blaze/base/sync/projectstructure/ModuleEditorImpl.java b/base/src/com/google/idea/blaze/base/sync/projectstructure/ModuleEditorImpl.java
@@ -39,6 +39,7 @@
 import com.intellij.openapi.roots.impl.ModifiableModelCommitter;
 import com.intellij.openapi.vfs.VfsUtil;
 import com.intellij.openapi.vfs.VirtualFile;
+
 import java.io.File;
 import java.io.IOException;
 import java.util.List;
@@ -118,8 +119,9 @@ public Module findModule(String moduleName) {
   public void commitWithGc(BlazeContext context) {
     List<Module> orphanModules = Lists.newArrayList();
     for (Module module : ModuleManager.getInstance(project).getModules()) {
-      if (!modules.containsKey(module.getName())) {
-        orphanModules.add(module);
+      if (!modules.containsKey(module.getName())
+              && !ExternalModuleProvider.EP_NAME.getExtensionList().stream().anyMatch(n -> n.isOwnedByExternalPlugin(module))) {
+          orphanModules.add(module);
       }
     }
     if (orphanModules.size() > 0) {