Rename a method to improve code clarity.

Methods that return collections should have plural names. (cherry picked from commit 58f05e8)
bazelbuild · Jul 17, 2023 · 8c21d04 · 8c21d04
1 parent 9356537
commit 8c21d04
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/base/src/com/google/idea/blaze/base/qsync/cache/ArtifactInfo.java b/base/src/com/google/idea/blaze/base/qsync/cache/ArtifactInfo.java
@@ -53,7 +53,7 @@ public abstract class ArtifactInfo {
   public abstract ImmutableList<Path> genSrcs();
 
   /** Workspace relative sources for this dependency, extracted at dependency build time. */
-  public abstract ImmutableSet<Path> source();
+  public abstract ImmutableSet<Path> sources();
 
   public static ArtifactInfo create(TargetArtifacts proto) {
     // Note, the proto contains a list of sources, we take the parent as we want directories instead
@@ -71,7 +71,7 @@ public TargetArtifacts toProto() {
         .addAllJars(jars().stream().map(Path::toString).collect(toImmutableList()))
         .addAllIdeAars(ideAars().stream().map(Path::toString).collect(toImmutableList()))
         .addAllGenSrcs(genSrcs().stream().map(Path::toString).collect(toImmutableList()))
-        .addAllSrcs(source().stream().map(Path::toString).collect(toImmutableList()))
+        .addAllSrcs(sources().stream().map(Path::toString).collect(toImmutableList()))
         .build();
   }
 

diff --git a/base/src/com/google/idea/blaze/base/qsync/cache/ArtifactTrackerImpl.java b/base/src/com/google/idea/blaze/base/qsync/cache/ArtifactTrackerImpl.java
@@ -228,7 +228,7 @@ public ImmutableSet<Path> getTargetSources(Path cachedArtifact) {
     Path artifactPath = cachePathToArtifactKeyMap.get(cachedArtifact);
     return artifacts.values().stream()
         .filter(d -> d.containsPath(artifactPath))
-        .map(ArtifactInfo::source)
+        .map(ArtifactInfo::sources)
         .flatMap(Set::stream)
         .collect(toImmutableSet());
   }