-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to have non-existent import entries in projectview
that pointing to …
#5689
Merged
ujohnny
merged 8 commits into
bazelbuild:master
from
dkashyn-sfdc:optional-imports-projectview
Dec 11, 2023
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a23d29a
Allow to have non-existent entries in `projectview` that pointing to …
dkashyn-sfdc 54a1ff2
Reordering of conditions for readability
dkashyn-sfdc 9215b8a
Merge branch 'master' into optional-imports-projectview
dkashyn-sfdc 1fabf5d
Merge remote-tracking branch 'origin/master' into optional-imports-pr…
dkashyn-sfdc ae15030
TryImport POC
dkashyn-sfdc 841a9aa
`try_import` instead of `import`
dkashyn-sfdc f1377b5
Some tests for try_import
dkashyn-sfdc b174bc6
test fix
dkashyn-sfdc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,6 +55,10 @@ public void assertHasErrors() { | |
assertThat(issues.stream().anyMatch(i -> i.getCategory() == Category.ERROR)).isTrue(); | ||
} | ||
|
||
public void assertHasNoErrors() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. in some cases there are issues but those are not errors. |
||
assertThat(issues.stream().anyMatch(i -> i.getCategory() == Category.ERROR)).isFalse(); | ||
} | ||
|
||
public void assertIssues(String... requiredMessages) { | ||
List<String> messages = Lists.newArrayList(); | ||
for (IssueOutput issue : issues) { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was unable to make it work with
Registry.is('bla', false)
for tests.