Skip to content

Commit

Permalink
Recommend http_archive() for installation
Browse files Browse the repository at this point in the history 
http_archive() is faster and uses less spaces than git_repository(),
which appears to have a jGit issue: bazelbuild/bazel#1515

Fixed #113
  • Loading branch information
@jart
jart committed Jul 16, 2016
1 parent a59f290 commit 0e3eade
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,9 @@ First you must [install][bazel-install] Bazel. Then you must add the following
to your `WORKSPACE` file:

```python
git_repository(
http_archive(
name = "io_bazel_rules_closure",
remote = "https://github.com/bazelbuild/rules_closure.git",
tag = "0.2.3",
url = "https://github.com/bazelbuild/rules_closure/archive/0.2.3.zip",
)

load("@io_bazel_rules_closure//closure:defs.bzl", "closure_repositories")
Expand Down

2 comments on commit 0e3eade

@gramic
Copy link
Contributor

@gramic gramic commented on 0e3eade Jul 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The archive 0.2.4.zip contains global directory "rules_closure-0.2.4" that should be stripped away via
strip_prefix = "rules_closure-0.2.4",

@jart
Copy link
Contributor Author

@jart jart commented on 0e3eade Jul 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Please sign in to comment.