Stricter validation of defs flags

bazelbuild · Jun 8, 2016 · 57db937 · 57db937
1 parent 20543dc
commit 57db937
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/closure/compiler/closure_js_binary.bzl b/closure/compiler/closure_js_binary.bzl
@@ -106,6 +106,11 @@ def _impl(ctx):
     files += [report]
     outputs += [report]
     args += ["--property_renaming_report=%s" % report.path]
+
+  # validate defs
+  for flag in ctx.attr.defs:
+    if not flag.startswith("--") or (" " in flag and "=" not in flag):
+      fail("Please use --flag=value syntax for defs")
   args += ctx.attr.defs
 
   # add gigantic list of files