Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to disable CSS output source map #129

Closed
hochhaus opened this issue Sep 6, 2016 · 2 comments
Closed

Allow user to disable CSS output source map #129

hochhaus opened this issue Sep 6, 2016 · 2 comments
Assignees
Labels

Comments

@hochhaus
Copy link
Contributor

hochhaus commented Sep 6, 2016

While updating some of our code to use rules_closure 0.3.0 I ran into google/closure-stylesheets#11. Basically, the CSS compiler crashes with a NullPointerException when source maps are enabled if a property value contains a comma. For example:

body {
  font-family: 'Roboto', sans-serif;
}

Unfortunately, for me, this is a show stopper for the upgrade. I don't see an easy way for me to disable the source map in the current API. Can we provide an override until this is fixed in the CSS compiler?

@hochhaus
Copy link
Contributor Author

hochhaus commented Sep 8, 2016

@jart Any time to offer feedback on this?

@jart jart added the P0 label Sep 8, 2016
@jart jart self-assigned this Sep 8, 2016
@jart jart added the bug label Sep 8, 2016
@jart
Copy link
Contributor

jart commented Sep 8, 2016

I'll try to get a release out today fixing this.

@jart jart closed this as completed in #138 Sep 21, 2016
jart pushed a commit that referenced this issue Sep 21, 2016
salvianreynaldi pushed a commit to salvianreynaldi/rules_closure that referenced this issue Oct 24, 2016
ptmphuong pushed a commit to ptmphuong/rules_closure that referenced this issue Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants