Add fine-grained Closure Library build rules #269
Conversation
jart
force-pushed
the
thin-library
branch
4 times, most recently
from
e611ef2
to
fcd0685
Compare
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # DO NOT EDIT -- bazel run //closure/library:regenerate -- "$PWD" |
There was a problem hiding this comment.
should auto-generated build files still have copyright header? the old build files did.
There was a problem hiding this comment.
BUILD files shouldn't need a copyright header at all.
| closure_js_library( | ||
| name = "announcer", | ||
| srcs = ["@com_google_javascript_closure_library//:closure/goog/a11y/aria/announcer.js"], | ||
| lenient = True, |
There was a problem hiding this comment.
what is the strategy for what has lenient set to True vs what doesn't? the all_js don't seem to and the overall top-level build rule doesn't either.
There was a problem hiding this comment.
lenient and suppress should only be specified if srcs is nonempty. Failure condition added.
| return '//%s:%s' % (os.path.dirname(path), file2name(path)) | ||
|
|
||
|
|
||
| def main(basejs, outdir): |
There was a problem hiding this comment.
this fn could use more comments throughout
| @@ -60,7 +54,6 @@ def unfurl(deps, provider=""): | |||
|
|
|||
| def collect_js(deps, | |||
| closure_library_base=None, | |||
| closure_library_deps=None, | |||
| has_direct_srcs=False, | |||
There was a problem hiding this comment.
why are the closure_library_deps no longer needed?
This change introduced a fine-grained build graph for the Closure Library. This is most useful when the Closure Compiler isn't being used. For example, it's now possible to depend on `@io_bazel_rules_closure//closure/library/object` which is 11mB smaller (in terms of naïvely concatenated JavaScript sources) than getting the same API from `@io_bazel_rules_closure//closure/library`. The latency of tools like Clutz should also be improved. The following additional changes needed to be made: - `deps.js` no longer needs to be an implicit dependency thanks to `transitionalforwarddeclarations.js`. - A `lenient` attribute is now available for `closure_js_library` which makes the compiler more easy-going. - `goog.labs`, `goog.ui`, and third party APIs may no longer be exported from `//closure/library` and `//closure/library:testing` by default.
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # DO NOT EDIT -- bazel run //closure/library:regenerate -- "$PWD" |
There was a problem hiding this comment.
BUILD files shouldn't need a copyright header at all.
| closure_js_library( | ||
| name = "announcer", | ||
| srcs = ["@com_google_javascript_closure_library//:closure/goog/a11y/aria/announcer.js"], | ||
| lenient = True, |
There was a problem hiding this comment.
lenient and suppress should only be specified if srcs is nonempty. Failure condition added.
|
Wonderful. This change brings Travis latency down from 16 to 9 minutes. That's even better than it was twelve months ago. See: https://travis-ci.org/bazelbuild/rules_closure/builds cc: @hochhaus |
This change introduced a fine-grained build graph for the Closure Library. This is most useful when the Closure Compiler isn't being used. For example, it's now possible to depend on `@io_bazel_rules_closure//closure/library/object` which is 11mB smaller (in terms of naïvely concatenated JavaScript sources) than getting the same API from `@io_bazel_rules_closure//closure/library`. The latency of tools like Clutz should also be improved. The following additional changes needed to be made: - `deps.js` no longer needs to be an implicit dependency thanks to `transitionalforwarddeclarations.js`. - A `lenient` attribute is now available for `closure_js_library` which makes the compiler more easy-going. - `goog.labs`, `goog.ui`, and third party APIs may no longer be exported from `//closure/library` and `//closure/library:testing` by default.
Add fine-grained Closure Library build rules
This change introduced a fine-grained build graph for the Closure Library. This
is most useful when the Closure Compiler isn't being used. For example, it's
now possible to depend on
@io_bazel_rules_closure//closure/library/objectwhich is 11mB smaller (in terms of naïvely concatenated JavaScript sources)
than getting the same API from
@io_bazel_rules_closure//closure/library.The latency of tools like Clutz should also be improved.
The following additional changes needed to be made:
deps.jsno longer needs to be an implicit dependency thanks totransitionalforwarddeclarations.js.A
lenientattribute is now available forclosure_js_librarywhich makesthe compiler more easy-going.
goog.labs,goog.ui, and third party APIs may no longer be exported from//closure/libraryand//closure/library:testingby default.