This should fix Issue #9 and allow use from bazel-HEAD again. #40
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
The CLA issue should be fixed -- I started using a different email for my git stuff awhile back, never told Google about it, it seems. I don't understand why travis seems to be upset, however. |
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
Hi Amanda. Thank you so much for making a contribution. I'm sorry I didn't get a chance to respond sooner. The CLA issue might be because the email address you used on the git commit itself, isn't what Google CLA bot has on file. I merged a couple other pull requests today. Could you take a look and see if the latest head fixes your problem? |
|
Amanda, I think your issue should be resolved with the latest release. I'm going to close this PR now. But I want you to know how grateful I am that you took the time to send us one. I hope we'll see more contributions from you in the future. |
|
Appologies for the delay in responding -- the deal with the CLA is that I startyed using the email of another google account for my git usages, and it seems unhappy with that fact. I imagine that #43 did indeed fix it, as it's very similar. I'm happy to keep comitting, just need to get the CLA fixed up. |
|
Awesome, I'm glad to hear that. Let me know if there's anything more I can be doing. |
|
Hey Amanda, I can help sort out the CLA issue. This might be the first time we've run into a GitHub account being mapped to two different emails in our CLA system, so you seem to have uncovered a bug. I'll see about getting that fixed. In the meantime, there may be a faster solution. Are you planning on using the darkdna email for all contributions going forward? If so, then the simplest thing would probably be to go to cla.developers.google.com while logged in with your gmail account (not the darkdna account), click "Edit Contact Information" for the CLA you signed, and then remove your GitHub Account Name. If you still want to be able to contribute with both email addresses (maybe for different projects, for example), then we'll need to wait until this bug gets investigated further and fixed. (Being tracked as b/28598113 in case anyone needs to reference this later) |
|
I'll do that then, since I'm planning on using the darkdna address for everything code-related from now on anyway -- thanks for the response. :) |
This fixes issue #9, however I have only tested using bazel-HEAD and the HEAD of this repository.
This change allows you to use the rules and their deps without having to copy the closure/ folder into your local project, by using a label name instead for build_file in the repositories.bzl