Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incremental type checking for goog modules #615

Merged
merged 2 commits into from
May 14, 2024
Merged

Fix incremental type checking for goog modules #615

merged 2 commits into from
May 14, 2024

Conversation

gkdn
Copy link
Collaborator

@gkdn gkdn commented May 14, 2024

  • Add CheckTypeSummaryWarningsGuard to ignore errors from ijs files.
  • Wrap modules in goog.modules for ijs files and sort them.
  • Add input delimiters to help with debugging.

@gkdn gkdn mentioned this pull request May 14, 2024
Closed
@gkdn gkdn merged commit 26321bf into master May 14, 2024
4 checks passed
@gkdn gkdn deleted the fixinc branch May 14, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jDramaix jDramaix jDramaix approved these changes

@soldair soldair Awaiting requested review from soldair soldair is a code owner

@gregmagolan gregmagolan Awaiting requested review from gregmagolan gregmagolan is a code owner

Assignees

@jDramaix jDramaix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkdn @jDramaix