Use full compilation for closure_js_test #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests should set CompilerOptions.exportTestFunctions = true. There's a flag for that in the google-internal runner, but it looks like we don't have one externally. |
| exporting `transitive_js_srcs`. Each source will be inserted into the webpage | ||
| in its own `<script>` tag based on a depth-first preordering. | ||
|
|
||
| - **harness:** (Label; required; default is |
|
I reviewed all the code and don't see anything major for improvement. Fully compiled tests are really cool! LGTM |
| @@ -42,16 +43,20 @@ JS_HIDE_WARNING_ARGS = [ | |||
| "--hide_warnings_for=.soy.js", | |||
There was a problem hiding this comment.
Can you remove ".soy.js" here? I think all .soy.js files live under bazel-out/local-fastbuild/genfiles/.
|
All comments addressed. @MatrixFrog Thanks for letting me know about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've addressed the feedback left by @Dominator008 and @MatrixFrog in #67. This was basically accomplished by changing
closure_js_testto be a build macro rather than a Skylark rule. JsChecker updates come later. Please take a look.The only difficulty I've really encountered is that
goog.testing.testSuitekeys need to be quoted. I would have assumed that since the type signature says they're strings, theADVANCEDproperty renamer wouldn't rename them? Also no one seems to quote them internally at Google. Is this intended behavior?CC: @hochhaus