Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

Expose entrypoint to py_image and py3_image rules #1264

Closed

Conversation

mmikitka
Copy link
Contributor

@mmikitka mmikitka commented Nov 7, 2019

For issue #1247

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmikitka
To complete the pull request process, please assign smukherj1
You can assign the PR to them by writing /assign @smukherj1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmikitka
Copy link
Contributor Author

mmikitka commented Nov 7, 2019

/gcbrun

@mmikitka
Copy link
Contributor Author

mmikitka commented Nov 7, 2019

/assign @smukherj1

@nlopezgi
Copy link
Contributor

nlopezgi commented Nov 7, 2019

the preferred solution for this case is to do:

py_image(
  name= "py_base",
   ...
)

container_image(
  name="some_container",
  base = ":py_base",
  entrypoint="<new entrypoint>",
  ...
)

Let me know if that does not work for you for some reason.

@nlopezgi
Copy link
Contributor

nlopezgi commented Nov 7, 2019

this is very similar to #498 (although the suggestion I made above is different than the one I made in #498, please do let me know if the suggestion works). Also see #309 for a longer discussion. Closing, but let me know if you want to reopen for some reason.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants