Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate wheel-building code out of //experimental #418

Merged
merged 7 commits into from
Feb 16, 2021
Merged

Graduate wheel-building code out of //experimental #418

merged 7 commits into from
Feb 16, 2021

Conversation

pstradomski
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe: Move wheel-building rules out of //experimental.

Does this PR introduce a breaking change?

  • Yes
  • No

No, the rules are still re-exported at the old location

FIXES #374

Rename from wheel.bzl to packaging.bzl to avoid confusion with existing whl.bzl
Keep a stub wheel.bzl file in the old location for backwards compatibility.
Copy link
Collaborator

@thundergolfer thundergolfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Now that this is out of experimental/, py_wheel probably warrants a mention in the README. But that is not a big deal and can be sorted out in a followup.

tools/BUILD Outdated Show resolved Hide resolved
@pstradomski pstradomski merged commit 6135186 into bazelbuild:master Feb 16, 2021
@pstradomski pstradomski deleted the graduate-wheel branch February 16, 2021 18:15
@UebelAndre
Copy link
Contributor

Could a new release be made for this change? Or what goes into making a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ship /experimental directory in released versions
3 participants