Fix flaky build and test failures on windows #2217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daivinhtran
force-pushed
the
fix-test-names
branch
2 times, most recently
from
b1d5428
to
ba11c6d
Compare
daivinhtran
force-pushed
the
fix-test-names
branch
from
ba11c6d
to
19a727f
Compare
added 4 commits
October 27, 2023 13:25
daivinhtran
force-pushed
the
fix-test-names
branch
from
b047189
to
62cc8ee
Compare
daivinhtran
force-pushed
the
fix-test-names
branch
from
62cc8ee
to
550a115
Compare
added 3 commits
October 27, 2023 15:29
daivinhtran
force-pushed
the
fix-test-names
branch
from
3b2f9c0
to
94b8be0
Compare
daivinhtran
changed the title
daivinhtran
changed the title
UebelAndre
requested changes
Oct 31, 2023
| - "-//test/unit/pipelined_compilation/..." | ||
| # The proto rules do not work on windows | ||
| - "-//proto/..." |
There was a problem hiding this comment.
Could we instead tag specific targets as incompatible with windows? How many targets fail on windows?
There was a problem hiding this comment.
Pretty much all proto targets fail on windows because rust_prost_toolchain fails building on windows after #1899 introduces a transition to make the filepath even longer with the config hash.
There was a problem hiding this comment.
@UebelAndre could we move this forward and disable windows the path length issues are taken care of?
There was a problem hiding this comment.
I’m not convinced we need to disable the unit tests but haven’t had time to figure out if transitioning for the panic PR is necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR initially patched #1899 to fix any unrelated errors and then reverted the PR. Two fixes in this PR:
rust_prost_toolchainnow fails with the hash introduced by the transition in Support-Cpanic=abort#1899. The hash makes the the path over the limit as mentioned in (1).