-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditional compilation deps #2607
Open
ericmcbride
wants to merge
18
commits into
bazelbuild:main
Choose a base branch
from
ericmcbride:conditional-compilation-deps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conditional compilation deps #2607
ericmcbride
wants to merge
18
commits into
bazelbuild:main
from
ericmcbride:conditional-compilation-deps
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmcbride
changed the title
DRAFT: Conditional compilation deps
Conditional compilation deps
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cfg_expr
use case of theFlag
predicate. AKAcfg(tokio_unstable)
orcfg(tokio_dump)
--cfg tokio_unstable
or--cfg tokio_coredump
cfg_expr
Some of my thoughts are, do we need to add metadata to CrateDependency to say we injected this value? Could this be leveraged in the future for optional dependencies so they dont have to be declared explicitly in the library? What were you looking to resolve in ?Support conditional compilation dependencies #1950