Allow rust_binary to depend on cc_library
#83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message and the documentation both say this is possible. Light testing seems to show that this is the only change required.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
CLAs look good, thanks! |
|
Looks like it was an oversight in #34, lgtm. @acmcarther ping :) |
|
Whoops, I guess this was missed in the original review. Lucky that the error immediately indicated that this was a bug! @neachdainn Thanks for the quick fix! LGTM |
acmcarther
pushed a commit
that referenced
this pull request
May 23, 2018
* Add support for depending on shared libraries on linux. * Use portable bash for TMPDIR check. * Move example 'matrix' to 'ffi/rust_calling_c'. * Use toolchain to get dylib/staticlib file extensions. * Skip dylib test targets on osx. * Simplify presubmit config. * Fix skipped labels. * Allow `rust_binary` to depend on `cc_library` (#83) The error message and the documentation both say this is possible. Light testing seems to show that this is the only change required. * Skip just rpath setup on non-linux. * Address review comments. * Attempt to clarify _setup_deps * Adjust provider test for field changes. * Actually provide correct patterns in test * Undo removing skipping of os check * Add FreeBSD toolchain. (#85) * Add os field to freebsd toolchain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the documentation and the error message say that it is possible for
rust_binarytargets to depend oncc_librarytargets. Currently, trying to do so results in an error.I believe this one small change is all that is necessary. I have tested this with my own project and it appears to work but I am unfamiliar enough with Bazel and Skylark that I am not 100% certain that it is correct.