fix kill-region advice, close bbatsov/prelude#899

[toctan]

The current kill-region advice does not play nice with rectangle-mark-mode, see #899

[toctan]

@bbatsov Anything wrong with this pull request?

[bbatsov]

The commit message is not capitalised.

I'd also change it to [Fix #899] Make the kill-region advice play nice with rectangle-mark-mode.

[toctan]

@bbatsov Updated.

[vamega]

Not only is this showing a warning it also breaks the functionality of Ctrl-W.
If I revert this patch, and Ctrl-W works in regular mode, but does not do what @toctan wished to achieve when rectangle-mark-mode is activated.

[toctan]

@vamega @mopsfelder I have test it with the latest emacs stable release, that is 24.5. Could you please post the output of M-x -> describe-variable -> rectangle-mark-mode here?

[FranklinChen]

C-w is broken right now. There is no rectangle-mark-mode defined. My Emacs version:

"GNU Emacs 24.5.1 (x86_64-apple-darwin14.3.0, NS apple-appkit-1347.57)
of 2015-05-17"

[vamega]

I evaluated (describe-variable 'rectangle-mark-mode) and got the following result

rectangle-mark-mode is void as a variable.

Documentation:
Not documented as a variable.

Here is the output from my messages buffer

Prelude is powering up... Be patient, Master vmadiath!
Loading personal configuration files in /home/vmadiath/.emacs.d/personal/preload...
Loading /home/vmadiath/.emacs.d/personal/preload/preload.el (source)...done
Loading Prelude's core...
ad-handle-definition: `ido-completing-read' got redefined
Loading /home/vmadiath/.emacs.d/savefile/recentf...done
.emacs.d/core/prelude-editor.el:Warning: reference to free variable
    `rectangle-mark-mode'
Loading Prelude's modules...
Loading /home/vmadiath/.emacs.d/prelude-modules.el (source)...
.emacs.d/elpa/ido-ubiquitous-20150630.926/ido-ubiquitous.el:Warning: reference
    to free variable `rectangle-mark-mode'
Warning: Unknown defun property `interactive-only' in flycheck-disable-checker
Warning: Unknown defun property `interactive-only' in flycheck-set-checker-executable
Loading /home/vmadiath/.emacs.d/prelude-modules.el (source)...done
Loading personal configuration files in /home/vmadiath/.emacs.d/personal...
Loading /home/vmadiath/.emacs.d/personal/custom.el (source)...done
Loading /home/vmadiath/.emacs.d/personal/org.el (source)...done
Loading /home/vmadiath/.emacs.d/personal/vmadiath.el (source)...done
Prelude is ready to do thy bidding, Master vmadiath!
Starting new Ispell process aspell with default dictionary...
Compiler-macro error for python-syntax-context: (void-function python-syntax--context-compiler-macro) [2 times]
Starting Emacs daemon.
in on-after-init hook: window-setup-hook
in make-frame
When done with this frame, type C-x 5 0
Mark set
if: Symbol's value as variable is void: rectangle-mark-mode
Quit

My emacs version is GNU Emacs 24.5.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.16.2) of 2015-04-20 on bitzer.hoetzel.info