Add hint about putting UUIDs in IMF filenames #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipnbbc
reviewed
Feb 29, 2024
There was a problem hiding this comment.
The uppercase T in {Type} would result in uppercase media types names. Would a full example for the given pattern help to highlight this? E.g. VIDEO_a145db5d-4623-4233-913f-15e16980b840.mxf
It looks like the app usage messages are missing this info. Could you also update the app usage messages (in the "Notes:" at the end) to state that if at least one letter is uppercase in {type}, {fp_uuid} etc. then the output will be made uppercase? E.g. "{Fp_uuid}` would result in uppercase letters in the UUID string.
philipnbbc
approved these changes
Mar 1, 2024
Matthew-Marks
force-pushed
the
filename_hint
branch
from
de27635
to
60ce997
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shame if that nice little enhancement gets forgotten about.