Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMAGEDAM-194: Add image pre-defined metadata fields #52

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

abdelrahmansd
Copy link

@abdelrahmansd abdelrahmansd commented Nov 10, 2020

What does this change?

  • Add pre-defined metadata fields to image from UI

How can success be measured?

  • The user is presented with the option of metadata fields to chose from that are not already populated on a given image.
  • As a user with the appropriate permission/authority, I am able to update the metadata of a given image that has previously been ingested from any source

Screenshots (if applicable)

Screenshot from 2020-11-16 16-28-03
Screenshot from 2020-11-16 16-29-48
Screenshot from 2020-11-16 16-30-03

Who should look at this?

Tested?

  • locally
  • on TEST

@paperboyo
Copy link

Hi, just couple of comments from me regarding the nature of the feature (not the code):

  1. Some of these fields do not need adding manually as even when they are missing in the image, they show up in the UI and allow adding/editing values (description, credit, byline)
  2. So it makes sense to allow adding only the ones that aren’t showing in UI when empty (or are showing under Show full metadata where they aren’t editable)
  3. Copyright notice field is a mistake and is going away (see this)
  4. This should disallow adding an already present field (eg Byline is legal to contain multiple values, but Grid doesn’t support it and should not support it by having two Byline fields)

TBH, this part of the app is a bit of a mess:

  • some fields are only editable during the upload stage , but only if they are present in the image (eg Copyright)
  • some fields show up in main UI, some only under Show full metadata (where they are not editable)
  • some fields show up even if empty, where others are conditional in being present in the original image

So there are discrepancies between upload screen, viewer (image page) and browser (search page). And between how fields are treated depending on their presence in the original. And on their importance.

@abdelrahmansd
Copy link
Author

Thanks, @paperboyo, I will apply those comments.

@abdelrahmansd abdelrahmansd force-pushed the feature/pre-defined-metadata branch 2 times, most recently from e454ddc to 772b343 Compare November 16, 2020 14:23
@abdelrahmansd abdelrahmansd changed the title IMAGEDAM-194: Add/Update image pre-defined metadata fields IMAGEDAM-194: Add image pre-defined metadata fields Nov 17, 2020
@abdelrahmansd abdelrahmansd merged commit 14bbe1e into bbc2 Nov 20, 2020
@abdelrahmansd abdelrahmansd deleted the feature/pre-defined-metadata branch November 20, 2020 10:50
@paperboyo paperboyo mentioned this pull request Dec 21, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants