Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade npm-run-all to v4.1.5 #991

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Conversation

ChrisBAshton
Copy link
Contributor

Fixes vulnerability: dominictarr/event-stream#116
See mysticatea/npm-run-all#150 (comment)

Supersedes #990. Shouldn't fail the Travis/Jenkins builds because package-lock.json wasn't deleted in this branch, only modified through npm commands.

  • Tests added for new features
  • Test engineer approval

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 9326 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Nov 26, 2018

Code Climate has analyzed commit dcd98bf and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 97.0% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@sareh sareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jamesbrumpton
Copy link
Contributor

LGTM

@ChrisBAshton ChrisBAshton merged commit f2461a1 into latest Nov 26, 2018
@ChrisBAshton ChrisBAshton deleted the remove-vulnerability-via-upgrade branch November 26, 2018 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants