-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chromedriver support #541
Merged
Merged
Chromedriver support #541
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
dc02ddd
add basic selenium/chromedriver support
shmargum f7704ac
add full page screenshots, add element-selector screenshots, add befo…
shmargum a6a3de5
add specs
shmargum faf1b2f
try adding chrome package to travis
shmargum 432322b
add support for individual before sript
shmargum b45c3b6
use chromedriver helper gem instead of manually installing
shmargum 0f7ae31
update README
shmargum f4b91bb
resize after js execution because page might change size
shmargum a776884
reuse driver and also bump version
shmargum 3df1918
add before capture js tests for chrome; comment out casperjs tests si…
shmargum 005c2b5
try installing chrome this way on travis
shmargum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
.bundle/* | ||
shots/ | ||
shots_chrome/ | ||
shots_history/ | ||
data.txt | ||
.DS_Store | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
2.3.3 | ||
2.4.1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,14 @@ | ||
sudo: false | ||
addons: | ||
apt: | ||
packages: | ||
- google-chrome-stable | ||
|
||
language: ruby | ||
rvm: | ||
- 2.3.3 | ||
before_install: | ||
- gem update | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this would update all the system gems -- not sure why we need it |
||
- gem --version | ||
script: bundle exec rspec | ||
- 2.4.1 | ||
script: | ||
- bundle exec rspec | ||
notifications: | ||
email: | ||
recipients: | ||
|
@@ -13,4 +17,3 @@ notifications: | |
on_success: never | ||
slack: | ||
secure: BgRAqwHabAtIBgtApDjyUiND2SNxd4sHMgq4ffnJ+EoMme6RSUAeK0G6LLyaGAk6YcpCeWRGOccEpzai87R3ckv6uycUVGxFcTvPmCEClakbUelWovVEyVT3hPLWznxJ8pz3EVB2+5aJnAsTg5M2ZnYtk3a5C1mrPS+WKceE/Ls= | ||
sudo: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
module Wraith | ||
VERSION = "4.0.1" | ||
VERSION = "4.1.0" | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
########## | ||
### NB: the paths in this YAML config are relative to the root of the Wraith directory, | ||
### as `bundle exec rspec` is run from the root. | ||
########## | ||
|
||
#Headless browser option | ||
browser: | ||
phantomjs: "chrome" | ||
|
||
# Type the name of the directory that shots will be stored in | ||
directory: 'shots_chrome' | ||
|
||
# Add only 2 domains, key will act as a label | ||
domains: | ||
afrique: "http://www.bbc.com/afrique" | ||
russian: "http://www.bbc.com/russian" | ||
|
||
#Type screen widths below, here are a couple of examples | ||
screen_widths: | ||
- 600 | ||
- 1280 | ||
|
||
#Type page URL paths below, here are a couple of examples | ||
paths: | ||
home: / | ||
home_menu: | ||
path: / | ||
selector: "#orb-nav-more" | ||
uk_index: /uk | ||
|
||
# (optional) JavaScript file to execute before taking screenshot of every path. Default: nil | ||
# before_capture: 'javascript/interact--chrome.js' | ||
# before_capture: 'javascript/wait--chrome.js' | ||
|
||
#Amount of fuzz ImageMagick will use | ||
fuzz: '20%' | ||
|
||
# (optional) The maximum acceptable level of difference (in %) between two images before Wraith reports a failure. Default: 0 | ||
threshold: 5 | ||
|
||
# (optional) Specify the template (and generated thumbnail sizes) for the gallery output. | ||
gallery: | ||
template: 'slideshow_template' # Examples: 'basic_template' (default), 'slideshow_template' | ||
thumb_width: 200 | ||
thumb_height: 200 | ||
|
||
# (optional) Choose which results are displayed in the gallery, and in what order. Default: alphanumeric | ||
# Options: | ||
# alphanumeric - all paths (with or without a difference) are shown, sorted by path | ||
# diffs_first - all paths (with or without a difference) are shown, sorted by difference size (largest first) | ||
# diffs_only - only paths with a difference are shown, sorted by difference size (largest first) | ||
# Note: different screen widths are always grouped together. | ||
mode: diffs_first |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
var callback = arguments[arguments.length-1]; | ||
document.body.innerHTML = " "; | ||
document.body.style['background-color'] = 'red'; | ||
callback(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
var callback = arguments[arguments.length-1]; | ||
document.body.innerHTML = " "; | ||
document.body.style['background-color'] = 'green'; | ||
callback(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
var callback = arguments[arguments.length-1]; | ||
var a = document.querySelector('.some-class'); | ||
a && a.click(); | ||
setTimeout(callback, 2000); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
var callback = arguments[arguments.length-1]; | ||
setTimeout(callback, 2000); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bumped the version since 2.3.3 is not installed by default on travis and 2.4.1 is