Security fixes in SMTP_SSL and SMTP_TLS strategies #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SMTP_SSL and SMTP_TLS transport strategies now validate certificates
by setting JavaMail's
mail.<protocol>.ssl.checkserveridentity
propertyto true.
Previously, no identity validation was performed, leaving SMTPS and
STARTTLS connections vulnerable to man-in-the-middle attacks. Without
identity validation, JavaMail accepts any certificate issued by a
JVM-trusted CA, regardless of the identity encoded in the certificate.
The SMTP_TLS transport strategy now requires STARTTLS support by setting
JavaMail's
mail.smtp.starttls.required
property to true.Previously, STARTTLS support was not required, enabling a man-in-the-middle
attack whereby an attacker could strip the STARTTLS request from an SMTP
connection, causing JavaMail to fall back to plaintext SMTP for
authentication and email transport.