Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundling forces with cargo-apk? #28

Closed
MarijnS95 opened this issue Sep 17, 2021 · 3 comments
Closed

Bundling forces with cargo-apk? #28

MarijnS95 opened this issue Sep 17, 2021 · 3 comments

Comments

@MarijnS95
Copy link

Hi! I'm one of the maintainers for android-ndk-rs, and occasionally use cargo-ndk to build a crate for Android that doesn't need the surrounding apk. Unfortunately cargo-ndk doesn't work with the R23 NDK due to an issue that has already been solved in ndk-build. I also couldn't get ANDROID_NDK_ROOT to work, presumably because cargo-ndk only recognizes ANDROID_NDK_HOME.

ndk-build is our crate for cross-compiling native binaries and creating apks, and is exactly focused at being reusable in ie. cargo-ndk. Since we're both pursuing the same goal and doing the exact same thing, would you be open to see if we can unify our projects and relieve/share the maintenance "burden"? I envision to start with simply comparing ndk-build to cargo-ndk and integrate any features that are missing, followed by migrating cargo-ndk over to ndk-build. We can optionally take cargo-ndk into the android-ndk-rs tree being another "frontend" CLI to ndk-build just like cargo-apk, if both parties are open to this.

Looking forward to your opinion!

@bbqsrc
Copy link
Owner

bbqsrc commented Sep 18, 2021

I envision to start with simply comparing ndk-build to cargo-ndk and integrate any features that are missing, followed by migrating cargo-ndk over to ndk-build.

Sounds good.

We can optionally take cargo-ndk into the android-ndk-rs tree being another "frontend" CLI to ndk-build just like cargo-apk, if both parties are open to this.

I'm not a big fan of monorepos but I am happy to make you a maintainer of this repo if your pull request is good. 😄

@MarijnS95
Copy link
Author

We can optionally take cargo-ndk into the android-ndk-rs tree being another "frontend" CLI to ndk-build just like cargo-apk, if both parties are open to this.

I'm not a big fan of monorepos but I am happy to make you a maintainer of this repo if your pull request is good.

Me neither, but it has proven useful for small utilities that share the same underlying crate(s) - it saves a ton of hassle having git references in Cargo.toml and/or submodules that constantly need to be updated in parallel. However, ndk-build is published and intended to be used by external crates as well, and cargo-ndk might be its first external user :)

@bbqsrc
Copy link
Owner

bbqsrc commented Oct 24, 2021

Rather than let this issue linger open, I'll close it for now. If you choose to make a pull request in the future that implements what was described, that would be great. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants