ROMSearch method #11
Merged
ROMSearch method #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ROMSearch now has two modes: the first is `filter_then_download` (default), which will use the dat file to filter, then only download relevant files. The second is `download_then_filter`, which will download everything and then filter. For data hoarders! - Ensure includes/excludes works the same as it does for ROMDownloader in GameFinder - Includes/excludes will now search dupes as well in GameFinder, for consistency - Ensure output directory exists before downloading files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filter_then_download(default), which will use the dat file to filter,then only download relevant files. The second is
download_then_filter, which will download everything and thenfilter. For data hoarders!