fix, clean, doc

bcaudan · Aug 12, 2014 · 160937f · 160937f
1 parent 004dcf1
commit 160937f
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 33 deletions.
diff --git a/README.md b/README.md
@@ -21,6 +21,11 @@ Real time console spec reporter for jasmine behavior-driven development testing
         success: 'green',
         failure: 'red',
         skipped: 'cyan'
+      },
+      prefixes: {
+        success: '✓ ',
+        failure: '✗ ',
+        skipped: '- '
       }
     }
 

diff --git a/example/example-spec.coffee b/example/example-spec.coffee
@@ -11,6 +11,11 @@ jasmine.getEnv().addReporter(new jasmine.SpecReporter({
     success: 'green',
     failure: 'red',
     skipped: 'cyan'
+  },
+  prefixes: {
+    success: '✓ ',
+    failure: '✗ ',
+    skipped: '- '
   }
 }))
 

diff --git a/package.json b/package.json
@@ -4,8 +4,8 @@
   "description": "Spec reporter for jasmine behavior-driven development framework",
   "main": "src/jasmine-spec-reporter.js",
   "scripts": {
-    "test": "./node_modules/jasmine-node/bin/jasmine-node --coffee --noStack spec",
-    "example": "./node_modules/jasmine-node/bin/jasmine-node --coffee example"
+    "test": "node node_modules/jasmine-node/bin/jasmine-node --coffee --noStack spec",
+    "example": "node node_modules/jasmine-node/bin/jasmine-node --coffee example"
   },
   "repository": {
     "type": "git",

diff --git a/spec/jasmine-spec-reporter.spec.coffee b/spec/jasmine-spec-reporter.spec.coffee
@@ -171,6 +171,7 @@ describe 'spec reporter', ->
           ''
         ]
 
+
       it 'should report skipped whith success', ->
         expect(new Test(@reporter,->
           @describe 'suite', ->
@@ -323,6 +324,7 @@ describe 'spec reporter', ->
               @failed()
         ).outputs).not.contains /failed suite/
 
+
       it 'should display not fully failed suite', ->
         outputs = new Test(@reporter,->
           @describe 'failed suite', ->
@@ -372,6 +374,7 @@ describe 'spec reporter', ->
         ).outputs)
         .contains /✗ failed spec \({time}\)/
 
+
   describe 'with prefixes set to empty strings', ->
     beforeEach ->
       @reporter = new jasmine.SpecReporter({displaySkippedSpec: true, prefixes: {success: '', failure: '', skipped: ''}})
@@ -394,13 +397,15 @@ describe 'spec reporter', ->
         ).outputs)
         .not.contains /✗/
 
+
       it 'should report skipped', ->
         expect(new Test(@reporter,->
           @describe 'suite', ->
             @xit 'skipped spec', ->
         ).outputs)
         .not.contains /-/
 
+
   describe 'with prefixes set to valid strings', ->
     beforeEach ->
       @reporter = new jasmine.SpecReporter({displaySkippedSpec: true, prefixes: {success: 'Pass ', failure: 'Fail ', skipped: 'Skip '}})
@@ -423,41 +428,14 @@ describe 'spec reporter', ->
         ).outputs)
         .not.contains /✗/
 
+
       it 'should report skipped', ->
         expect(new Test(@reporter,->
           @describe 'suite', ->
             @xit 'skipped spec', ->
         ).outputs)
         .not.contains /-/
 
-  describe 'with prefixes not set', ->
-    beforeEach ->
-      @reporter = new jasmine.SpecReporter({displaySkippedSpec: true, prefixes: {} })
-
-    describe 'when spec', ->
-      it 'should report success', ->
-        expect(new Test(@reporter,->
-          @describe 'suite', ->
-            @it 'successful spec', ->
-              @passed()
-        ).outputs)
-        .contains /✓/
-
-
-      it 'should report failure', ->
-        expect(new Test(@reporter,->
-          @describe 'suite', ->
-            @it 'failed spec', ->
-              @failed()
-        ).outputs)
-        .contains /✗/
-
-      it 'should report skipped', ->
-        expect(new Test(@reporter,->
-          @describe 'suite', ->
-            @xit 'skipped spec', ->
-        ).outputs)
-        .contains /-/
 
   describe 'with jasmine callback hack', ->
     beforeEach ->

diff --git a/src/jasmine-spec-reporter.js b/src/jasmine-spec-reporter.js
@@ -123,7 +123,7 @@ SpecDisplay.prototype = {
       this.ensureSuiteDisplayed(spec.suite);
       var result = spec.results().description;
       var duration = this.displaySpecDuration ? ' (' + spec.duration + ')' : '';
-      this.log(this.prefixes.success + result.success + duration)
+      this.log(this.prefixes.success.success + result.success + duration)
     }
   },
 
@@ -133,7 +133,7 @@ SpecDisplay.prototype = {
       this.ensureSuiteDisplayed(spec.suite);
       var result = spec.results().description;
       var duration = this.displaySpecDuration ? ' (' + spec.duration + ')' : '';
-      this.log(this.prefixes.failure + result.failure + duration);
+      this.log(this.prefixes.failure.failure + result.failure + duration);
       this.displayErrorMessages(spec);
     }
   },
@@ -142,7 +142,7 @@ SpecDisplay.prototype = {
     if (this.displaySkippedSpec) {
       this.ensureSuiteDisplayed(spec.suite);
       var result = spec.results().description;
-      this.log(this.prefixes.skipped + result.skipped)
+      this.log(this.prefixes.skipped.skipped + result.skipped)
     }
   },