Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker buildx imagetools to check tag_fallback #18

Merged
merged 3 commits into from
May 19, 2023

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented May 19, 2023

Builds were happening even when nothing had changed and a valid fallback was provided. Something probably changed, because the previous image check just stopped working.

Resolves bcgov/quickstart-openshift#1025.

@DerekRoberts DerekRoberts self-assigned this May 19, 2023
@DerekRoberts DerekRoberts added the bug Something isn't working label May 19, 2023
@DerekRoberts DerekRoberts marked this pull request as ready for review May 19, 2023 02:35
Copy link
Contributor

@mishraomp mishraomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DerekRoberts DerekRoberts merged commit 0ba3a30 into main May 19, 2023
@DerekRoberts DerekRoberts deleted the bug/fixSmartRebuild branch May 19, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builder action is always building for public-code
2 participants