changes to police trxs

bcgov · Jul 22, 2024 · 404e2d3 · 404e2d3
1 parent 308c3bb
commit 404e2d3
Showing 1 changed file with 44 additions and 33 deletions.
diff --git a/backend/webapi/Features/DigitalEvidenceCaseManagement/Commands/CaseAccessRequest.cs b/backend/webapi/Features/DigitalEvidenceCaseManagement/Commands/CaseAccessRequest.cs
@@ -81,51 +81,60 @@ public async Task<IDomainResult> HandleAsync(Command command)
                     return DomainResult.Failed();
                 }
 
-                using var trx = this.context.Database.BeginTransaction();
-
-                try
+                using (var trx = this.context.Database.BeginTransaction())
                 {
-                    // not a tools request and no key provided
-                    if (!command.ToolsCaseRequest && string.IsNullOrEmpty(command.Key))
-                    {
-                        // case has no RCC number - we'll record and move on
-                        this.logger.LogCaseMissingKey(command.CaseId, dto.Jpdid);
-                    }
-
-                    if (command.ToolsCaseRequest)
+                    try
                     {
-                        var toolsCase = await this.caseMgmtClient.GetCase(this.config.AUFToolsCaseId);
-                        if (toolsCase == null)
+                        // not a tools request and no key provided
+                        if (!command.ToolsCaseRequest && string.IsNullOrEmpty(command.Key))
                         {
-                            throw new AccessRequestException("Tools case not found");
+                            // case has no RCC number - we'll record and move on
+                            this.logger.LogCaseMissingKey(command.CaseId, dto.Jpdid);
                         }
-                        else
+
+                        if (command.ToolsCaseRequest)
                         {
-                            this.logger.LogRequestToolsCase(toolsCase.Id, dto.Jpdid);
-                            command.Key = toolsCase.Key;
-                            command.CaseId = toolsCase.Id;
-                            command.Name = toolsCase.Name;
-                            command.AgencyFileNumber = "AUF Tools Case";
+                            var toolsCase = await this.caseMgmtClient.GetCase(this.config.AUFToolsCaseId);
+                            if (toolsCase == null)
+                            {
+                                throw new AccessRequestException("Tools case not found");
+                            }
+                            else
+                            {
+                                this.logger.LogRequestToolsCase(toolsCase.Id, dto.Jpdid);
+                                command.Key = toolsCase.Key;
+                                command.CaseId = toolsCase.Id;
+                                command.Name = toolsCase.Name;
+                                command.AgencyFileNumber = "AUF Tools Case";
+                            }
                         }
-                    }
 
-                    var subAgencyRequest = await this.SubmitAgencyCaseRequest(command); //save all trx at once for production(remove this and handle using idempotent)
+                        var subAgencyRequest = await this.SubmitAgencyCaseRequest(command);
 
-                    // var exportedEvent = this.AddOutbox(command, subAgencyRequest, dto);
 
-                    await this.PublishSubAgencyAccessRequest(dto, subAgencyRequest);
+                        var addedRows = await this.context.SaveChangesAsync();
+                        if (addedRows > 0)
+                        {
+                            this.logger.LogRequestCase(command.RequestId, command.AgencyFileNumber, command.PartyId);
+                            await trx.CommitAsync();
 
-                    await this.context.SaveChangesAsync();
-                    await trx.CommitAsync();
-                }
-                catch (Exception ex)
-                {
+                            await this.PublishSubAgencyAccessRequest(dto, subAgencyRequest);
+                        }
+                        else
+                        {
+                            this.logger.LogDigitalEvidenceAccessTrxFailed($"Failed to store record for Request:{command.RequestId} Party:{command.PartyId} {command.AgencyFileNumber}");
 
-                    this.logger.LogDigitalEvidenceAccessTrxFailed(ex.Message.ToString());
-                    await trx.RollbackAsync();
-                    return DomainResult.Failed();
-                }
+                        }
 
+                    }
+                    catch (Exception ex)
+                    {
+
+                        this.logger.LogDigitalEvidenceAccessTrxFailed(ex.Message.ToString());
+                        await trx.RollbackAsync();
+                        return DomainResult.Failed();
+                    }
+                }
                 return DomainResult.Success();
 
             }
@@ -228,4 +237,6 @@ public static partial class SubmittingAgencyLoggingExtensions
     public static partial void LogCaseMissingKey(this ILogger logger, int caseId, string? username);
     [LoggerMessage(4, LogLevel.Information, "Tools case {caseId} request - for user {username}.")]
     public static partial void LogRequestToolsCase(this ILogger logger, int caseId, string? username);
+    [LoggerMessage(5, LogLevel.Information, "Saved request {requestId} for {agencyFileNumber} party: {partyId}")]
+    public static partial void LogRequestCase(this ILogger logger, int requestId, string? agencyFileNumber, int partyId);
 }