PIMS-1955 Entity Updates

[dbarkowsky]

🎯 Summary

PIMS-1955
PIMS-1987

Changes

• Drop metadata column from project. All previous data there was covered by the timestamp/notes/tasks/monetary tables.
• Ensure that the timestamps stored directly on the project are updated when the project is submitted/updated.
• Drop IsSystem and EmailVerified columns from user table. We don't currently use IsSystem, and EmailVerified was never used.
• Drop LeaseExpiry, EncumbranceReason, OccupantName, LeasedLandMetadata from Building table. Sparsely used in old PIMS. Not currently used.
• Drop Zoning, ZoningPotential from Parcel table. Sparsely used in old PIMS. Not currently used.
• Drop SiteId and IsVisibleToOtherAgencies from Property entity. There was a plan to use SiteId to store geolocator id, but it was never implemented. I don't think we need/plan to use this anymore. IsVisibleToOtherAgencies could be determined by the property and potential projects it is in.
• Removed Email and KeycloakId unique constraints from the User table. Email was an issue when users with accounts from the silver Keycloak tried to log in now that it's on gold. Their guid would be different, but the email was the same. KeycloakId was an issue

🔰 Checklist

• I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.

• I have performed a self-review of my code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation where required.
• I have tested my changes to the best of my ability.
• My changes generate no new warnings.

[github-actions]

🚀 Deployment Information

The Express API Image has been built with the tag: 2639. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

[codeclimate]

Code Climate has analyzed commit 87a24a5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 71.4% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.2%.

View more on Code Climate.

[LawrenceLau2020]

Works well, tested updating a building and parcel, and also tested switching the status of a project to pre-marketing, Approved for ERP, Approved for Exemption, and Disposed and the dates seem to be saved correctly. No issues detected.