PIMS-2029 ERP Visibility

[dbarkowsky]

🎯 Summary

PIMS-2029

Goal

When a project is in ERP, both it and its properties should be viewable by users from outside agencies.

See the JIRA ticket for a full list of requirements: https://citz-imb.atlassian.net/browse/PIMS-2029?atlOrigin=eyJpIjoiNDQ1OTMyNjQ3YTM1NDRlYjlmODAwMTg5MmJhZDQ2YmMiLCJwIjoiaiJ9

Changes

• Checks to allow for retrieval of singular properties and projects by ID if the project is in ERP status.
• Added project_status_id to the map properties view and the property union view. It only shows the project status of the most recent project. This should always be the correct one, as business rules don't allow for putting properties in multiple active projects.
• Added colour to PropertyRow element if the property is in ERP
• Added colour to row on Property table if property is in ERP
• Added select filter option to get properties in ERP
• Users should now see ERP properties and projects in the tables/map, even if they are outside of the user's agency

Testing

• As a General User, try to visit various properties/projects both in and out of ERP status. You should only be able to see ERP-related ones.
• On the map page, properties in ERP should have their PropertyRow element coloured and containing the text In ERP Project
• On the Property Table, properties in and ERP project will be coloured
• There's also a hidden column that you can reveal to allow for filtering on this most recent project status

🔰 Checklist

• I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.

• I have performed a self-review of my code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation where required.
• I have tested my changes to the best of my ability.
• My changes generate no new warnings.

[github-actions]

🚀 Deployment Information

The Express API Image has been built with the tag: 2654. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

[github-actions]

🚀 Deployment Information

The React APP Image has been built with the tag: 2654. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

[codeclimate]

Code Climate has analyzed commit 7ef6090 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 89.7% (50% is the threshold).

This pull request will bring the total coverage in the repository to 92.8%.

View more on Code Climate.

[TaylorFries]

Works very well.
as a general user only properties in a project with status 14 (In ERP) are visible on the inventory list and on the map. I was unable to open other properties.
colour to properties on the active inventory list and map list look good.
filter on the table works as expected.
No issues detected.

[LawrenceLau2020]

Looks good, the filtering works well and tested viewing properties and projects in ERP with no issues, and also not able to view properties and projects that are not approved for ERP.

Do we want the same kind of filter for "In ERP Project" for the map, as right now with an agency that has over 100 properties on a map, it's kind of hard to tell which are in ERP.

[dbarkowsky]

Do we want the same kind of filter for "In ERP Project" for the map, as right now with an agency that has over 100 properties on a map, it's kind of hard to tell which are in ERP.

Yes, that should be doable. I included the ProjectStatusId field on the map filter schema, so I think it's possible in the backend. Would probably just need a frontend control that we could add in the filter area. Will make a separate ticket for this.