Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-2027 BCSC Provider Options #2675

Merged
merged 10 commits into from
Sep 18, 2024
Merged

PIMS-2027 BCSC Provider Options #2675

merged 10 commits into from
Sep 18, 2024

Conversation

dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Sep 13, 2024

🎯 Summary

PIMS-2027

This PR adds the BCSC option whenever a provider is presented in the frontend.
The BCSC provider in the token is just the Keycloak integration client ID unfortunately, so it looks for that.

Changes

  • Added helper function to return Provider string
  • Replaced individual checks with this helper function for consistency
  • Added sso client id to config so we have something to check BCSC for
  • Changed KeycloakUserId column from uuid type to varchar type. The id from Keycloak for BCSC is not a true uuid because it contains values outside [0-9a-f]. This would cause the database to reject the BCSC value when it was entered. Note, the KeycloakUserId field will not populate correctly still, because the sso-express package does not recognize BCSC as an option yet.

Testing

  • Log in with user who doesn't have access, check that provider on access form is correct
  • Check provider column on user table
  • Check provider area on user details

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

🚀 Deployment Information

The Express API Image has been built with the tag: 2675. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

codeclimate bot commented Sep 13, 2024

Code Climate has analyzed commit 16d029d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 92.8%.

View more on Code Climate.

Copy link

🚀 Deployment Information

The React APP Image has been built with the tag: 2675. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link
Collaborator

@LawrenceLau2020 LawrenceLau2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! I'm approving it, but I am seeing that the user's display_name, first_name, and last_name in the user table was stored in all caps.

@dbarkowsky
Copy link
Collaborator Author

Note: Test user for BC Services Card has name info in all uppercase. Normal users shouldn't have this issue.

@dbarkowsky dbarkowsky merged commit 2aa895d into main Sep 18, 2024
13 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-2027-BCSC-Cases branch September 18, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants