-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIMS-2083 Remove Keycloak Roles Code #2676
Conversation
Code Climate has analyzed commit b5cb759 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 93.0%. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, looks like it's no longer using the SSO Keycloak roles at all now. Changed user to a general user and it updated the role_id correctly in the database, also tested changing the role in Keycloak which has no effect as expected.
🎯 Summary
PIMS-2083
This ticket removes code that handled anything related to updating Keycloak roles.
This includes when a user logs in, is updated, when the cron job ran, etc.
This will break the following until the auth checks are also updated to use the database instead:
We should not push this past DEV until the rest of the work is done.
🔰 Checklist