Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP-7157 Project dropdowns #3594

Merged
merged 11 commits into from
Nov 16, 2023
Merged

Conversation

asanchezr
Copy link
Collaborator

NOTE: working on unit tests - will add them to the pr later

image

@asanchezr asanchezr added the enhancement New feature or request label Nov 15, 2023
@asanchezr asanchezr self-assigned this Nov 15, 2023
Copy link
Contributor

✅ No secrets were detected in the code.

1 similar comment
Copy link
Contributor

✅ No secrets were detected in the code.

Copy link
Contributor

✅ No secrets were detected in the code.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #3594 (0c60977) into dev (5a8afb2) will increase coverage by 5.10%.
The diff coverage is 89.47%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3594      +/-   ##
==========================================
+ Coverage   69.58%   74.68%   +5.10%     
==========================================
  Files        1371      899     -472     
  Lines       33893    18670   -15223     
  Branches     6307     5291    -1016     
==========================================
- Hits        23583    13944    -9639     
+ Misses      10055     4726    -5329     
+ Partials      255        0     -255     
Flag Coverage Δ
unittests 74.68% <89.47%> (+5.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...end/src/components/common/form/TypeaheadSelect.tsx 100.00% <100.00%> (ø)
...features/mapSideBar/project/add/AddProjectForm.tsx 100.00% <ø> (ø)
...s/projectDetails/update/UpdateProjectContainer.tsx 94.91% <100.00%> (ø)
source/frontend/src/utils/financialCodeUtils.ts 23.07% <ø> (ø)
...frontend/src/features/mapSideBar/project/models.ts 92.85% <78.57%> (-0.39%) ⬇️

... and 474 files with indirect coverage changes

Copy link
Contributor

✅ No secrets were detected in the code.

@asanchezr asanchezr merged commit 3337769 into bcgov:dev Nov 16, 2023
9 checks passed
@asanchezr asanchezr deleted the psp-7157-project-dropdowns branch November 16, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants