Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psp 7081 cancellation status and note. #3596

Merged
merged 4 commits into from
Nov 18, 2023

Conversation

devinleighsmith
Copy link
Collaborator

No description provided.

@devinleighsmith devinleighsmith added the enhancement New feature or request label Nov 16, 2023
@devinleighsmith devinleighsmith self-assigned this Nov 16, 2023
@devinleighsmith devinleighsmith changed the title Psp 7081 Psp 7081 cancellation status and note. Nov 16, 2023
Copy link
Contributor

✅ No secrets were detected in the code.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #3596 (14f466f) into dev (c76b13f) will decrease coverage by 0.01%.
The diff coverage is 78.57%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3596      +/-   ##
==========================================
- Coverage   69.61%   69.61%   -0.01%     
==========================================
  Files        1372     1372              
  Lines       33931    33968      +37     
  Branches     6328     6339      +11     
==========================================
+ Hits        23621    23646      +25     
- Misses      10055    10067      +12     
  Partials      255      255              
Flag Coverage Δ
unittests 69.61% <78.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
source/backend/api/Controllers/LookupController.cs 100.00% <100.00%> (ø)
...pi/Models/Concepts/AcquisitionFile/AgreementMap.cs 100.00% <100.00%> (ø)
source/frontend/src/constants/API.ts 100.00% <100.00%> (ø)
...ideBar/acquisition/tabs/agreement/update/models.ts 100.00% <100.00%> (ø)
.../frontend/src/models/generate/GenerateAgreement.ts 100.00% <100.00%> (ø)
...ce/backend/dal/Repositories/AgreementRepository.cs 73.46% <0.00%> (-1.54%) ⬇️
...cquisition/tabs/agreement/detail/AgreementView.tsx 75.00% <50.00%> (-5.96%) ⬇️
...ource/backend/dal/Repositories/LookupRepository.cs 0.00% <0.00%> (ø)
...isition/tabs/agreement/update/AgreementSubForm.tsx 75.00% <84.21%> (+10.71%) ⬆️

... and 1 file with indirect coverage changes

@@ -11,6 +11,7 @@ public void Register(TypeAdapterConfig config)
.Map(dest => dest.AgreementId, src => src.AgreementId)
.Map(dest => dest.AcquisitionFileId, src => src.AcquisitionFileId)
.Map(dest => dest.AgreementType, src => src.AgreementTypeCodeNavigation)
.Map(dest => dest.AgreementStatusType, src => src.AgreementStatusTypeCodeNavigation)
.Map(dest => dest.AgreementDate, src => src.AgreementDate)
//.Map(dest => dest.IsDraft, src => src.IsDraft) TODO: Fix this
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be removed now that the status covers is draft

Copy link
Contributor

✅ No secrets were detected in the code.

@FuriousLlama FuriousLlama merged commit a2d94fc into bcgov:dev Nov 18, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants