Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP-7441: FT-REG: Lease & License - Unable to create new licenses #3658

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

asanchezr
Copy link
Collaborator

No description provided.

@asanchezr asanchezr added the bug Something isn't working label Dec 14, 2023
@asanchezr asanchezr self-assigned this Dec 14, 2023
Copy link
Contributor

✅ No secrets were detected in the code.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #3658 (5a70abb) into dev (591af05) will decrease coverage by 5.56%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3658      +/-   ##
==========================================
- Coverage   69.40%   63.85%   -5.56%     
==========================================
  Files        1373      471     -902     
  Lines       34427    15378   -19049     
  Branches     6487     1044    -5443     
==========================================
- Hits        23895     9819   -14076     
+ Misses      10276     5302    -4974     
- Partials      256      257       +1     
Flag Coverage Δ
unittests 63.85% <100.00%> (-5.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...kend/dal/Repositories/AcquisitionFileRepository.cs 21.05% <ø> (ø)
source/backend/dal/Repositories/LeaseRepository.cs 19.23% <100.00%> (+7.20%) ⬆️

... and 904 files with indirect coverage changes

Copy link
Contributor

✅ No secrets were detected in the code.

@asanchezr asanchezr merged commit 1f7c7e1 into bcgov:dev Dec 14, 2023
8 of 9 checks passed
@asanchezr asanchezr deleted the psp-7441-lease-bug branch December 14, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants