psp-7275 complete a disposition file. psp-7785, psp-7322, psp-7568 #3740
Conversation
|
✅ No secrets were detected in the code. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #3740 +/- ##
==========================================
- Coverage 75.62% 75.58% -0.04%
==========================================
Files 1447 1448 +1
Lines 37650 38373 +723
Branches 7062 7271 +209
==========================================
+ Hits 28473 29006 +533
- Misses 8899 9073 +174
- Partials 278 294 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
✅ No secrets were detected in the code. |
| && dispositionFile.DispositionFileStatusTypeCode == EnumDispositionFileStatusTypeCode.COMPLETE.ToString() | ||
| && currentDispositionFile.PimsDispositionFileProperties.Count > 0) | ||
| { | ||
| DisposeofProperties(dispositionFile); |
There was a problem hiding this comment.
nit disposeOfProperties
There was a problem hiding this comment.
this is a function, why would it be lowercase?
There was a problem hiding this comment.
I meant capitalization of the O in Of
| else if (currentDispositionFile.DispositionFileStatusTypeCode != EnumDispositionFileStatusTypeCode.COMPLETE.ToString() | ||
| && dispositionFile.DispositionFileStatusTypeCode == EnumDispositionFileStatusTypeCode.COMPLETE.ToString() | ||
| && currentDispositionFile.PimsDispositionFileProperties.Count > 0) |
There was a problem hiding this comment.
this looks like good logic to be put in a different solver
There was a problem hiding this comment.
To be honest I'd rather we discuss the "solver" pattern. I think that pattern was added to the code base without a group discussion.
There was a problem hiding this comment.
Wouldn't have been better creating extension methods for the Disposition File instead of creating the "solver" approach to determine the Disposition file operability?
devinleighsmith
force-pushed
the
psp-7275
branch
from
bf48f41
to
0320c52
Compare
|
✅ No secrets were detected in the code. |
devinleighsmith
force-pushed
the
psp-7275
branch
from
56b613e
to
50cd4a5
Compare
|
✅ No secrets were detected in the code. |
devinleighsmith
force-pushed
the
psp-7275
branch
from
1b7a8a9
to
f06d054
Compare
devinleighsmith
force-pushed
the
psp-7275
branch
from
cc763f0
to
1002fdc
Compare
|
✅ No secrets were detected in the code. |
devinleighsmith
force-pushed
the
psp-7275
branch
from
1002fdc
to
a375745
Compare
|
✅ No secrets were detected in the code. |
devinleighsmith
force-pushed
the
psp-7275
branch
from
a375745
to
1002fdc
Compare
# Conflicts: # source/frontend/src/features/mapSideBar/disposition/tabs/fileDetails/detail/DispositionSummaryView.test.tsx # source/frontend/src/features/mapSideBar/disposition/tabs/fileDetails/detail/update/UpdateDispositionForm.test.tsx # source/frontend/src/features/mapSideBar/disposition/tabs/fileDetails/detail/update/__snapshots__/UpdateDispositionForm.test.tsx.snap # source/frontend/src/features/mapSideBar/disposition/tabs/offersAndSale/OffersAndSaleView.test.tsx
devinleighsmith
force-pushed
the
psp-7275
branch
from
1002fdc
to
62d340a
Compare
|
✅ No secrets were detected in the code. |
devinleighsmith
changed the title
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
No description provided.