Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psp-7548 ensure last update/date time reflects diposition file sub-entities correctly. #3744

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

devinleighsmith
Copy link
Collaborator

No description provided.

@devinleighsmith devinleighsmith added the enhancement New feature or request label Jan 26, 2024
@devinleighsmith devinleighsmith self-assigned this Jan 26, 2024
Copy link
Contributor

✅ No secrets were detected in the code.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1d974e9) 75.65% compared to head (77aa0b8) 75.75%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3744      +/-   ##
==========================================
+ Coverage   75.65%   75.75%   +0.09%     
==========================================
  Files        1448     1448              
  Lines       37910    38076     +166     
  Branches     7133     7136       +3     
==========================================
+ Hits        28682    28844     +162     
- Misses       8945     8949       +4     
  Partials      283      283              
Flag Coverage Δ
unittests 75.75% <97.12%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...kend/dal/Repositories/DispositionFileRepository.cs 92.00% <100.00%> (+3.49%) ⬆️
...es/mapSideBar/disposition/DispositionContainer.tsx 92.03% <100.00%> (+0.96%) ⬆️
...eatures/mapSideBar/disposition/DispositionView.tsx 95.34% <ø> (ø)
...apSideBar/disposition/router/DispositionRouter.tsx 43.75% <ø> (ø)
...apSideBar/disposition/tabs/DispositionFileTabs.tsx 89.28% <ø> (ø)
...tails/detail/update/UpdateDispositionContainer.tsx 100.00% <100.00%> (ø)
...eBar/shared/update/properties/UpdateProperties.tsx 74.02% <100.00%> (ø)
...tion/tabs/offersAndSale/OffersAndSaleContainer.tsx 70.00% <0.00%> (-2.42%) ⬇️
...sal/update/UpdateDispositionAppraisalContainer.tsx 81.25% <66.66%> (-2.63%) ⬇️
...positionOffer/add/AddDispositionOfferContainer.tsx 70.37% <50.00%> (-2.71%) ⬇️
... and 2 more

Copy link
Contributor

✅ No secrets were detected in the code.

@FuriousLlama
Copy link
Collaborator

@devinleighsmith please note #3753 for deleted entries

Copy link
Contributor

github-actions bot commented Feb 9, 2024

✅ No secrets were detected in the code.

@devinleighsmith devinleighsmith merged commit d0850ec into bcgov:dev Feb 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants